Merged
Conversation
format_item() can trigger lazy loading of archive metadata (e.g. hostname, username, size) from the repository. Previously it was called after archive.delete(), which caused Archive.DoesNotExist for pruned archives. Fix: call formatter.format_item() early, before any deletion takes place. Also added a test.
…ckup#9416 here it was not a problem currently, because format_archive(archive_info) does not load the archive from the repo, but only uses the given archive_info contents.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9422 +/- ##
==========================================
+ Coverage 76.50% 76.52% +0.01%
==========================================
Files 85 85
Lines 14818 14820 +2
Branches 2214 2214
==========================================
+ Hits 11337 11341 +4
+ Misses 2803 2802 -1
+ Partials 678 677 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Format archive-related log output early, before the archive is deleted from the repo.
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)